Question about rg_remove_entity and SetThink/Touch

[z0h1r-LK]

Hi :3
I wanna just know, what's correct

When remove an entity, What's correct method:

SetThink(entity, "") // Unset Think callback before remove entity.
SetTouch(entity, "")
rg_remove_entity(entity)

or remove that directly :

rg_remove_entity(entity)

Thanks in advance

 

[zlodey]

SetTouch
Purpose: The SetTouch function assigns a touch callback to an entity. This callback is triggered when another entity comes into contact with it.


rg_remove_entity
Purpose: This function is used to remove an entity from the game. It effectively deletes the specified entity, making it no longer part of the game world.

 

[xpombi4]

I might be wrong, but as far as I know, deleting the entity via rg_remove_entity, removes the SetThink/Touch, so you dont have to do it beforehand.

 

[Vaqtincha]

removes the SetThink/Touch

I don't see this in the source code.

https://github.com/rehlds/ReAPI/blob/master/reapi/src/natives/natives_misc.cpp#L2744

https://github.com/rehlds/ReGameDLL_CS/blob/1579273f62ccbf6b25ac468b90a616baf8609b2d/regamedll/dlls/util.cpp#L1450

but I think this is much safer than EngFunc_RemoveEntity

 

[z0h1r-LK]

Vaqtincha That's interesting! So? I need to unset Think and Touch callbacks for entity before remove it!!

 

[BlackSignature]

В большинстве случаев, достаточно rg_remove_entity()

Спойлер

#include amxmodx
#include fakemeta
#include reapi

public plugin_init() {
    register_srvcmd("MakeEnt", "srvcmd_MakeEnt")
}

public srvcmd_MakeEnt() {
    new pEnt = rg_create_entity("info_target")
    
    new iThink = get_ent_data(pEnt, "CBaseEntity", "m_pfnThink")
    new iTouch = get_ent_data(pEnt, "CBaseEntity", "m_pfnTouch")
    
    server_print("[1]: pEnt %i, m_pfnThink %i, m_pfnTouch %i", pEnt, iThink, iTouch)
    
    SetThink(pEnt, "OnThink")
    SetTouch(pEnt, "OnTouch")
    
    iThink = get_ent_data(pEnt, "CBaseEntity", "m_pfnThink")
    iTouch = get_ent_data(pEnt, "CBaseEntity", "m_pfnTouch")
    
    server_print("[1]: pEnt %i, m_pfnThink %i, m_pfnTouch %i", pEnt, iThink, iTouch)
    
    rg_remove_entity(pEnt)
    
    iThink = get_ent_data(pEnt, "CBaseEntity", "m_pfnThink")
    iTouch = get_ent_data(pEnt, "CBaseEntity", "m_pfnTouch")
    
    server_print("[2]: pEnt %i, m_pfnThink %i, m_pfnTouch %i", pEnt, iThink, iTouch)

    return PLUGIN_HANDLED
}

public OnThink(pEnt) { }
public OnTouch(pTouched, pToucher) { }

 

[fl0wer]

Удалять энтити через RemoveEntity не совсем небезопасно, так как если следующая в кадре энтити будет ссылаться на твою, то будет краш.
Альтернатива - FL_KILLME, удаляет энтити в конце кадра, но тут нюанс, что touch может блокировать удаление.

И как написал Vaqtincha rg_remove_entity удаляет безопасно, так как ставится FL_KILLME, и убирается солидность.

 

[Vaqtincha]

Спасибо Радиусу за информацию где они (кэлбеки) очищаются сами: https://github.com/rehlds/ReAPI/blo...b5ec7ffde6cf25c0e213c/reapi/src/main.cpp#L138